For Scott, Emma, Lavrai and Tom
Bug, Javascript, Lightbox Add commentsversion 0.11.1.2, version 0.11.1.3
..and other people experiencing problems with folders with spaces in the name.
I found the bug causing the filemtime error and corrected the problem. The %20 codes from the URI should have been translated back to spaces. ![]()
Also, the Lightbox links have been corrected. The code for the links to the images that weren’t on display in Thumbs view or Slide view are now placed in a correct HTML element.
I have uploaded the new files to the trunk. You can download the new version of the plugin from the WordPress Plugin Directory
Go to version 0.11.1.3
Could you please let me know below if this version finally solves your problems?
Thanks Marcel … you offer great support!
@Emma,
I’ll put the widget on my To Do list.
thanks
Marcel .. The spaces issue has now resolved for me, thanks!
Also so has the sorting of the folders .. but if I use the sidebar widget to list folders then they are still not sorted but they are OK on the gallery page.
Yes – sounds better than previous description Marcel!
Thanks,
Scott
@Scott,
Yes, I have looked at the javascript for the Lightbox and it appears that the caption is only updated with non-empty strings. You could change it like this:
at line 332 of lightbox.js add after the accolade
}:else {this.caption.update(" ").show();
}
So it will use a single space as caption in case the title string is empty.
Does that help?
Could indeed be with the Lightbox…
See example here: http://www.genfab.com/photo-albums/?file=2003/2/Im001681.jpg
View lightbox then click next.
Hey Scott
Hm, but where?
I have also images without a description, but I don’t see any duplicate descriptions.
http://brimosoft.nl/gallery/?file=folder_1/
Also, when I look at the page html source code, the description is in
title=''as it should.Could it be an error in the Lightbox javascript?
Hey Marcel,
Noticed another very minor issue…
If you view an image in the lightbox with a description, and then follow Next link (within lightbox) to an image without a description – the previous description will still be shown for this next image. I guess theres a description string that is not being cleared.
Cheers
Scott
Thanks for the quick response Marcel! I really appreciate what you’ve done with this plugin.
@Tom,
Thank you for noticing!
The link is there just for previewing.
I’ll fix it
in a couple of days.You can download already a new version from the WordPress Plugin Directory. It’s not on the update list yet.
I don’t want to disturb the users with another update this soon.
Unfortunately the weird Lightbox display persists with Safari but I use FF most of the time so this isn’t so much a problem for me.
This is not new but I get 404′s when I click on an image in file manager. When I hover over the image the path to the image excludes the “?” before “file=filename/some.jpg”. Under the new folder section the permalink structure includes the “?”. Adding the “?” to the path structure directly in the address bar locads the image properly for editing etc. as it should in file manager.
Yep – looks good. I’m happy!
Thanks Marcel!!
It looks good now.
Files with spaces do not give an error : http://brimosoft.nl/gallery/?file=folder_3/copy%20of%20folder%203/
Quotes display correctly in Lightbox : http://brimosoft.nl/gallery/?file=folder_1/IMAGE_058.jpg
We’re almost there…
Clicking should work when you select ‘Manual’ in the Lazyest Gallery Settings page.
htmlspecialchars does work, with ENT_QUOTES. Working on it because quotes also give trouble in the caption edit box.
Thanks Marcel!
htmlspecialchars didn’t fix it? I have lots of old descriptions I dont want to really go through and fix with new quotes to get around this…
On the per-folder sort… Perhaps I’m thick but it doesn’t seem to be working for me. When I click the headers on the photo descriptions edit page – nothing happens. I tried with both Firefox 3 as well as IE 7. Am I looking in the right spot?
Thanks,
Scott
@Scott:
I have uploaded new files to the trunk
On the %20 error: Sorry, that was a lousy line of code.
On lightbox: That problem occurs because the title element of the link is also enclosed in straight single quotes. I’ll see what happens if I do a htmlspecialchars. You could also use ‘ and ’
(edit: that doesn’t work, better use curly quotes ‘ or ’)
On per-folder sort: You can sort folders by filename, caption or date by clicking on the table header on Media, Description, or Date and then save the folder. The Slide sorter should work properly now.
thanks for your patience
Noticed something else – not sure if it’s a prob with LG or lightbox…
Captions with ‘s in them are getting cut off at that point when viewed in the lightbox. See http://www.genfab.com/photo-albums/?file=2005/51/Im003205.jpg for an example.
Thanks
Scott
Marcel,
One more thing… I’m finding the global sort option (Name, Date, Manual) of limited use. I need per album settings, since I have many albums already sorted how I want via filename – but then don’t show up in the correct order via Manual.
Think you could add per album sort options? The global setting would then just be the default for new albums…
Thanks,
Scott
Hey Marcel,
Unfortunately your patch didnt fix the problem with the spaces. In lazyest-folders.php, your line:
str_replace(“%20″, ” “, $dir);
should be:
$dir = str_replace(“%20″, ” “, $dir);
Is that a proper fix tho? Do you not need to URL decode $dir to handle other potential encoded chars?
Also – I am still sorting by Name, however the order seems arbitrary at times. The thumbnail page shows the correct order, but the Next and Back links dont follow the same order….? See this album for example: http://www.genfab.com/photo-albums/?file=2008/C-hakone/
Thanks,
Scott